fix: PublishedNewsImagesPermissionsV2UpgradePlugin have error when updating from 6.5.4 to 6.5.5 - EXO-75897 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dating from 6.5.4 to 6.5.5 - EXO-75897 Before this fix, the UP has some problems - When there is an error, it does not explain which news have the error - When the UP have an error, it is not relaunched at next startup - The error should not occurs This commit fix the 3 problems : - Throw an error to not consider the UP as success when an error is founded - Add logs to explain which news has a problem - Update the regular expression : when the news contains 2 images, one following the other, the regexp does not stop at the end of the src attribute, which generate an error when trying to read the jcr node by uuid
rdenarie
force-pushed
the
fix/task-75897
branch
from
fec5d62 to
b104260
Compare
Jihed525
approved these changes
Dec 11, 2024
|
Jihed525
pushed a commit
that referenced
this pull request
Dec 11, 2024
…dating from 6.5.4 to 6.5.5 - EXO-75897 (#263) Before this fix, the UP has some problems When there is an error, it does not explain which news have the error When the UP have an error, it is not relaunched at next startup The error should not occurs This commit fix the 3 problems : Throw an error to not consider the UP as success when an error is founded Add logs to explain which news has a problem Update the regular expression : when the news contains 2 images, one following the other, the regexp does not stop at the end of the src attribute, which generate an error when trying to read the jcr node by uuid (cherry picked from commit 71f7a70)
Jihed525
pushed a commit
that referenced
this pull request
Dec 11, 2024
…dating from 6.5.4 to 6.5.5 - EXO-75897 (#263) Before this fix, the UP has some problems When there is an error, it does not explain which news have the error When the UP have an error, it is not relaunched at next startup The error should not occurs This commit fix the 3 problems : Throw an error to not consider the UP as success when an error is founded Add logs to explain which news has a problem Update the regular expression : when the news contains 2 images, one following the other, the regexp does not stop at the end of the src attribute, which generate an error when trying to read the jcr node by uuid (cherry picked from commit 71f7a70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the UP has some problems
This commit fix the 3 problems :