Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parallel tool call evaluation to ToolCallAccuracy metric #1687

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added parallel tool call evaluation to ToolCallAccuracy metric #1687

wants to merge 2 commits into from

Conversation

sahusiddharth
Copy link
Contributor

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 17, 2024
@sahusiddharth sahusiddharth marked this pull request as draft November 18, 2024 05:19
@sahusiddharth sahusiddharth marked this pull request as ready for review November 18, 2024 05:20
@shahules786
Copy link
Member

shahules786 commented Nov 19, 2024 •
edited
Loading

I think this is a better solution for now, compared to introducing new metric just for parallel like #1665. But ideally what we need is an interface where use could both in single run. Ie there can be tool calls in single agentic run that should be made in parelle and ones that could be made in sequence. I think we will need another iteration on agentic evals to get there
@jjmachan should we consider merging this for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmachan jjmachan Awaiting requested review from jjmachan

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue about tool call metrics.
2 participants
@sahusiddharth @shahules786