Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google gemini #677

Closed

Conversation

joy13975
Copy link
Contributor

@joy13975 joy13975 commented Feb 28, 2024

This change allows one to use langchain-google-genai and simply

generator = TestsetGenerator.with_google(...)

just like one would with with_openai() and get on with life.
Initial tests show no errors in embedding and testset generation. Prompt adaptations work on condition of #676 being merged first.


CI/CD check fail: langchain-google-genai requires Python >=3.9, <4.0

@@ -8,6 +8,7 @@ dependencies = [
"langchain-core",
"langchain-community",
"langchain_openai",
"langchain-google-genai",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of making this an optional dependency?
something like ragas[google].

I'm waiting for our approval to use GCP so will test these after that

@joy13975
Copy link
Contributor Author

joy13975 commented Mar 1, 2024

I actually think #670 could be a better way of dealing with different vendors.
However, one thing that still needs to be fixed is temperature arg being a bit of a mess (having and arg but not actually using it) + being unnecessarily (?) passed into the Langchain LLM it sometimes causes errors if the Langchain LLM isn't expecting it as an arg such as in #656

@jjmachan
Copy link
Member

hey @joy13975 I agree that #670 is turning out to be the better implementation, so we'll merge that in.
as for #656 yeah that needs work and will try to get it sorted

@joy13975 joy13975 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants