Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contribution: infinity-integration #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

contribution: infinity-integration #834

wants to merge 1 commit into from

Conversation

michaelfeil
Copy link

@michaelfeil michaelfeil commented Apr 2, 2024 •
edited
Loading

#596 this PR adds support for various embeddings

Also fixes:

  • make format had no purpose in the CI - it would not verify that code is formatted (help in code-review) - added make format-check
  • SentenceTransformer - import at runtime.
  • adds pytest-asyncio: pytest.mark.asyncio there was a previous test - these tests are skipped when it is not installed.
  • typing and other minor

Feel free to commit directly to the branch.

@michaelfeil
Copy link
Author

Hey! @jjmachan @shahules786 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmachan jjmachan Awaiting requested review from jjmachan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelfeil