(fix) Validation situations where Expo returns a 200 with an error #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0duaht
changed the title
aroeczek-old
suggested changes
Aug 23, 2018
|
@0duaht Look like everything is ok with PR code, I didn't spot mentioned commit. |
|
yep, just test it this and it works. Can somebody from expo merge this request? |
kevinzhangftw
pushed a commit
to nano3labs/expo-server-sdk-ruby
that referenced
this pull request
Sep 4, 2018
|
I don't understand why the first element is returned every time, it seems to me like it should always be an array rather than always a single value 🤔 |
|
any movement on this? |
|
Closed in favor of #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures with data validation cos the Hash is being converted to an array