Correctly handle error parsing for 502/503/504s and batched errors #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could submit multiple requests, and receive multiple responses. If the 2nd one failed, it was not correctly identifying the type of error that occurred.
expo's servers will return non-json errors for things like the service being down. let's handle them and not throw a JSON::ParserError
|
@jeremylightsmith checkout #29 and see if that addresses this. I'm pretty sure by getting back all error messages, this is no longer a problem, but then again, I didn't specifically solve for those 500 level errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles: