This repository has been archived by the owner on May 12, 2020. It is now read-only.
Allow the use of an animated ScrollView #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the renderScrollComponent props returns an <Animated.ScrollView>, use component._component as a ref to access the ScrollView component
|
Instead of relying on the Animated ScrollView's private state, can you mix in https://github.com/expo/react-native-scrollable-mixin with Animated ScrollView so its public interface matches ScrollView's? That way we just need to make this change to Animated ScrollView once instead of changing every component that wraps a ScrollView. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the renderScrollComponent props returns an <Animated.ScrollView>, use component._component as a ref to access the ScrollView component