Preserve The Specified Timezone In Parse #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a string into a Time using the optional timezone parameter, set the location of the Time to the timezone's location so that Format uses that timezone.
cwarden
added a commit
to octoberswimmer/batchforce
that referenced
this pull request
Apr 23, 2024
When parsing a string into a Time using the optional timezone parameter to `date`, set the location of the Time to the timezone's location so that Format uses that timezone. See expr-lang/expr#633
cwarden
added a commit
to octoberswimmer/batchforce
that referenced
this pull request
Apr 23, 2024
When parsing a string into a Time using the optional timezone parameter to `date`, set the location of the Time to the timezone's location so that Format uses that timezone. See expr-lang/expr#633
|
Let's add mode tests for this use case? |
Add test when timezone is used to parse a date-time. Add test when timezone is irrelevant because it's a date.
I added a couple more in 42ff6c6. Can you think of other use cases that need to be covered? |
antonmedv
approved these changes
Apr 24, 2024
Closed
|
I think we not need this PR any more. Here is the logic: If parsed date has a TZ data date("2023-04-23T00:30:00.000+0100", "2006-01-02T15:04:05-0700", "America/Chicago")
2023-04-23 00:30:00 +0100 +0100Without TZ data, third param is used as TZ: date("2023-04-23T00:30:00.000", "2006-01-02T15:04:05", "America/Chicago")
2023-04-23 00:30:00 -0500 CDTSo we do not need implicit convert with In any more. |
❯ date("2023-04-23T00:30:00.000", "2006-01-02T15:04:05", "America/Chicago")
2023-04-23 00:30:00 -0500 CDT
❯ date("2023-04-23T00:30:00.000", "2006-01-02T15:04:05", "America/Chicago").In(timezone("America/Chicago"))
2023-04-23 00:30:00 -0500 CDT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a string into a Time using the optional timezone parameter, set the location of the Time to the timezone's location so that Format uses that timezone.