Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preview mode for pull requests #1501

Closed
wants to merge 1 commit into from

Conversation

lucasraziel
Copy link

@lucasraziel lucasraziel commented Apr 28, 2024

Added a PR Preview to CI using rossjrw/pr-preview-action@v1

closes #1491

 - add preview.yml with gh action rossjrw/pr-preview-action@v1
@UlisesGascon
Copy link
Member

Thanks for the proposal @lucasraziel!

I think we will need to have some capability of running previews from PRs generated in forks, but currently they are not supported:

This Action does not currently support deploying previews for PRs from forks.
See more details here

I don't have a lot of experience with Jekyll previews, but maybe something like gostatic can solve the preview problem: gostatic Jekyll GitHub Action. Since we will deploy the changes directly in a different environment (gostatic), what do you think about this approach?

I just found gostatic on a google search, so not sure if the new provider is the best option, but the free tier seems to cover out needs.

@lucasraziel
Copy link
Author

I will check about It on next weekend and/or will look for other alternatives.

@UlisesGascon UlisesGascon changed the title Issue #expressjs#1491 add preview mode for pull requests Apr 29, 2024
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepting this as it is would be destructive, so we cannot

our gh-pages branch is our main/production branch in this repo. this action commits to gh-pages to deploy previews under a preview dir namespace

the action does have the ability to commit the previews to a separate repo, which could work but is extra maintenance burden

@jonchurch
Copy link
Member

jonchurch commented May 2, 2024

Im planning to add netlify deploy previews since we can get those for free via their open source license. We can't leverage this repo's gh-pages for previews without committing to our production branch. This is going to have to be an integration, requiring admin perms, so I'll set it up.

@jonchurch jonchurch closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand CI functionality to preview changes from PR
3 participants