Test both tinygo and standard go #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can pull my changes on |
Separating example into a different module makes life harder, without significant benefits.
The new code should work with both Go and TinyGo. Also move, then main.go to separate folders, that way different IDE-s and tools work with them better.
|
@bhelx note I've rebased the code. |
|
@nilslice If they need to be downloaded one option would be to make them part of a release. (Rather than part of the source code) |
|
Yea that's preferable -- especially since Go will pull down all of this into the system cache including the wasm. |
|
Having the wasm modules in the repo is convenient, but can be pretty annoying to work with in git. Moving them to a release instead is a good idea! |
|
Do you want me to add the release thing in this PR or in a separate one? |
bhelx
approved these changes
Oct 26, 2023
|
@egonelbre this looks good to me! Let's do follow ups in other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for both std go and tinygo.
It also does some project cleanup:
.wasmfiles, because it looks like it's not necessary to commit them.workfile and example submodule, because they cause more problems than they solve (in this case)