-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin.CallWithContext method #60
Add plugin.CallWithContext method #60
Conversation
This method allows calling plugin functions with a custom context.
Let me know if you want me to also document this method in the README or update any other docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, I left one small feedback
That'd be great! |
b0a29d1
to
803d680
Compare
Added a note to the README! I didn't want to add a new section to not clutter the document too much as it is already quite lengthy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I will just wait for @zshipko to take a look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR adds a new method that allows calling plugin functions with a custom context.
This will allow developers to call extism plugins with custom timeouts and cancellation.