JNA callback should check inputs and outputs for null. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clearly CI is not fixed yet because |
This addresses extism#27 once we merge extism/extism#760 and release a new version of libextism. This PR simply check the parameters for null and the counts to be valid, in preparation for extism/extism#760 which otherwise would cause a NullPointerException when outputs and inputs are empty. Signed-off-by: Edoardo Vacchi <[email protected]>
evacchi
force-pushed
the
null-check-hostfuncs-callback
branch
from
16a9d1e to
e87d25f
Compare
zshipko
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
The changes look good - let's wait to merge until after extism/extism#760 is merged so we can re-run CI to make sure it's passing
|
looks fine! merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #27 once we merge extism/extism#760 and release a new version of libextism.
This PR simply check the parameters for null and the counts to be valid, in preparation for extism/extism#760 which otherwise would cause a NullPointerException when outputs and inputs are empty.