fix: warnings with new libextism - don't unpack even 0 bytes from NUL…

…L pointers
extism · Oct 9, 2024 · 754e681 · 754e681
1 parent 64f4e61
commit 754e681
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Extism/lib/Extism/Function.pm b/Extism/lib/Extism/Function.pm
@@ -91,16 +91,16 @@ sub set_namespace {
 
 sub load_raw_array {
   my ($ptr, $elm_size, $n) = @_;
+  $n or return [];
   my $input_array = unpack('P'.($elm_size * $n), pack('Q', $ptr));
   my @input_packed = unpack("(a$elm_size)*", $input_array);
   return \@input_packed;
 }
 
 sub host_function_caller_perl {
     my ($current_plugin, $input_ptr, $input_len, $output_ptr, $output_len, $user_data) = @_;
-    #print Dumper(\@_);
     local $Extism::CurrentPlugin::instance = $current_plugin;
-    my $input_packed = \@{load_raw_array($input_ptr, 16, $input_len)};
+    my $input_packed = load_raw_array($input_ptr, 16, $input_len);
     my @input = map {
       my $type = unpack('L', $_);
       my $value = substr($_, 8);
@@ -126,6 +126,7 @@ sub host_function_caller_perl {
     }
     my @outputs = $user_data->{func}(@input);
     scalar(@outputs) <= $output_len or croak "host function returned too many outputs";
+    $output_len or return;
     {
         my $i = 0;
         foreach my $item (@{$user_data->{conversions}{outputs}}) {