Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: libextism rollup host context, fuel, http response, compiled plugin #2

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: libextism rollup host context, fuel, http response, compiled plugin #2

merged 4 commits into from
Nov 27, 2024

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Nov 27, 2024

@G4Vi G4Vi requested a review from zshipko November 27, 2024 22:23
zshipko
zshipko approved these changes Nov 27, 2024
View reviewed changes
Copy link

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good from what I can tell as someone who can barely read Perl.

The bindings handling in Perl looks pretty awesome though!

@G4Vi G4Vi merged commit e7b3cfe into main Nov 27, 2024
16 checks passed
@G4Vi G4Vi deleted the gavin/20241126-feat-libextism-rollup-host-context-compiled-plugin branch December 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G4Vi @zshipko