Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Host Functions of PHP 7.4 #23

Merged
merged 6 commits into from
Jul 3, 2024
Merged

fix: Host Functions of PHP 7.4 #23

merged 6 commits into from
Jul 3, 2024

Conversation

oatmael
Copy link
Contributor

@oatmael oatmael commented Jul 3, 2024

Fixes issue #22 that causes host functions with arguments to not work on PHP 7.4.
See issue for context.

@oatmael oatmael changed the title Update input / output enum cast to map C Enum outside of FFI fix: Host Functions of PHP 7.4 Jul 3, 2024
@mhmd-azeez mhmd-azeez self-requested a review July 3, 2024 07:43
mhmd-azeez
mhmd-azeez approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mhmd-azeez mhmd-azeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! I will wait for the rate limit to go away and run the CI again and then merge the PR

@mhmd-azeez mhmd-azeez merged commit ac61e14 into extism:main Jul 3, 2024
4 checks passed
@mhmd-azeez mhmd-azeez mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmd-azeez mhmd-azeez mhmd-azeez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oatmael @mhmd-azeez