IBX-6451: Calculating the size of the dropdown element has been changed #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e remaining height to the bottom of the element
GrabowskiM
requested changes
Aug 31, 2023
mateuszdebinski
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Sep 1, 2023
dew326
approved these changes
Sep 1, 2023
bogusez
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as itemsContainerTop may be too large relative to the remaining height of the bottom element at times. Therefore, a calculation was added on how much is left from the top of the modal to a given element. To check whether this value is greater or smaller than itemsContainerTop, also I did not subtract DROPDOWN_MARGIN from this value, because the margin is the size of the element
Checklist:
$ composer fix-cs)