Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#46] 경매 상품 결제(포인트) 기능 추가 #47

Merged
merged 8 commits into from
Dec 1, 2024
Merged

[#46] 경매 상품 결제(포인트) 기능 추가 #47

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
07db482
feat: Point 엔티티 추가
JIWON27 Nov 23, 2024
a7f1358
feat: 포인트 충전/차감 기능 추가
JIWON27 Nov 23, 2024
92ffb6d
refactor: Test UserFixtures 폴더명 변경
JIWON27 Nov 23, 2024
a01c0d0
feat: 경매 가격 입찰 메서드에 포인트 차감 코드 추가
JIWON27 Nov 24, 2024
ba26c10
fix: 피드백 반영
JIWON27 Nov 25, 2024
448808b
feat: 경매 상품 최고가 변경 시 이전 최고가 제시의 포인트 롤백
JIWON27 Nov 25, 2024
0aabd8b
fix: 포인트 롤백해주는 기능 수정
JIWON27 Nov 25, 2024
772d18d
feat: 입찰 실패했을때도 포인트 다시 돌려주도록 추가
JIWON27 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions module-api/src/main/java/com/example/moduleapi/service/auction/AuctionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ private Long processBid(CustomUserDetails user, BidRequest bidRequest, Long prod
throw new BiddingFailException(user.getUser().getUserId(), bidRequest.getBiddingPrice(), productId);
}
// 포인트 돌려주기
PointAmount pointAmount = new PointAmount(userIdAndCurrentPrice.getSecond().intValue());
pointService.chargePoint(user, pointAmount);
pointService.rollbackPoint(userIdAndCurrentPrice.getFirst(), userIdAndCurrentPrice.getSecond().intValue());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis 최고가 정보 변경 전에 포인트를 롤백해주도록 추가했습니다.
이러면 실제 결제 시 포인트 부족 문제를 해결할 수 있을 것 같습니다!
혹시 제가 놓치고 있는 부분이 있을까요?!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금은 괜찮아보여요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 감사합니다~!

return updateRedisBidData(user, highestBidMap, bidRequest, productId);
}

Expand Down
6 changes: 6 additions & 0 deletions module-api/src/main/java/com/example/moduleapi/service/point/PointService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ public int deductPoint(CustomUserDetails userDetails, PointAmount pointAmount) {

point.minus(pointAmount.getAmount());
return point.getAmount();
}

// 포인트 롤백
@Transactional
public void rollbackPoint(Long userId, int plusAmount) {
Point point = pointRepository.findByUserId(userId);
point.plus(plusAmount);
}

private static void validateDeductPoint(PointAmount pointAmount, User user, Point point) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배치에서 차감을 한다고 할 때, 이 사람이 다른 경매도 참여해서 실제 결제시에는 포인트가 부족할 수도 있겠네요!
그거에 대한 생각도 해보면 좋을 것 같아요!

Copy link
Collaborator Author

@JIWON27 JIWON27 Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

경매 입찰 시도할때 가격만큼 포인트에서 차감을 시킨 다음에 낙찰받지 못하면 다시 포인트 돌려주는 방식으로 포인트 부족 문제를 해결할 수 있을꺼같은데 이 방식은 어떤지 궁금합니다!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 저번 멘토링때 얘기 나눴던 것 같네요! 전 좋은 방법 같습니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 감사합니다!

Expand Down
Loading