Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ortographic projection #1096

Closed
mrdeveloperdude opened this issue Dec 10, 2023 · 11 comments
Closed

Add support for ortographic projection #1096

mrdeveloperdude opened this issue Dec 10, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers help wanted Please help with this issue! type:enhancement New feature or request
Milestone

Comments

@mrdeveloperdude
Copy link

As a user of f3d I would like to see support for orthographic projection.

Currently only perspective projection is supported. My use case is that I will render thumbnails of CAD models and it is customary to use orthographic projection in CAD.

It can possibly be faked by moving the camera far away and setting a low camera angle. Possible pitfalls of this hack is floating point precision problems, poor z-buffer dynamic range use and more.

@mwestphal mwestphal added the type:enhancement New feature or request label Dec 10, 2023
@mwestphal
Copy link
Contributor

Indeed a nice addition, shouldnt be too hard to add.

@mwestphal mwestphal added the good first issue Good for newcomers label Dec 10, 2023
@Meakk
Copy link
Member

Meakk commented Dec 10, 2023

For reference if someone wants to give it a try: https://vtk.org/doc/nightly/html/classvtkCamera.html#a87b276a44eb1817aa388c89dc9becfc5

Obviously we need an option to toggle it.

@aemreaydin
Copy link

I'd like to work on this as my first issue. I'm trying to write a simple Vulkan Engine as a hobby project and would love to work on f3d as well to learn more about graphics systems going forward!

@mwestphal
Copy link
Contributor

Hi @aemreaydin !

You are very welcome! We have been discussing this issue on discord, did you join already ?

https://discord.f3d.app

@Meakk
Copy link
Member

Meakk commented Dec 12, 2023

There's a draft by @lknknm done here #942 if you want to take over.

@mwestphal
Copy link
Contributor

@kidharb so do you wanna try your hand at this one ?

@kidharb
Copy link
Contributor

kidharb commented Jan 27, 2024

Yes, I'm just not sure regarding how the baselines work. So I've been trying to run the ctests locally which has led me down a path of learning cmake.
Should I just push the code, which is just aemreaydin code?

@mwestphal
Copy link
Contributor

As you prefer, let me know if you need any help understanding how it works.

@mwestphal mwestphal assigned kidharb and unassigned aemreaydin Jan 27, 2024
@mwestphal mwestphal added this to F3D Feb 3, 2024
@mwestphal mwestphal moved this to In progress in F3D Feb 10, 2024
@mwestphal mwestphal added this to the 2.4.0 milestone Feb 10, 2024
@mwestphal
Copy link
Contributor

Partially addresed by #1235

@mwestphal
Copy link
Contributor

Still need a command line option, are you will to add it @kidharb ?

@mwestphal mwestphal moved this from In progress to Done in F3D Mar 17, 2024
@mwestphal
Copy link
Contributor

Fixed by #1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Please help with this issue! type:enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants