feat: add zoom to mouse position #1199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
=======================================
Coverage 96.42% 96.43%
=======================================
Files 131 131
Lines 8083 8103 +20
=======================================
+ Hits 7794 7814 +20
Misses 289 289 ☔ View full report in Codecov by Sentry. |
|
This should be testable with an interactive test, if not, with a VTKExtensions test. Let me know if you need any help with that: https://f3d.app/doc/dev/TESTING.html |
|
Hi @0x006E , need any help moving forward ? If adding an interactive test is a bit complicated, I understand that and I will be happy to take care of it after you merge. |
0x006E
force-pushed
the
add-zoom-to-mouse
branch
from
52a7c62 to
96362f9
Compare
0x006E
force-pushed
the
add-zoom-to-mouse
branch
from
96362f9 to
d94c246
Compare
|
please update https://github.com/f3d-app/f3d/blob/master/doc/user/INTERACTIONS.md accordingly |
Have done the same |
|
Thanks a lot for your contribution @0x006E ! |
* feat: add zoom to mouse position * fix: remove check for pararllel projection * test(interaction): add zoom to mouse * fix(zoom-to-mouse): remove unreachable code * docs(interaction): add zoom to mouse position * fix(zoom-to-mouse): make static
* feat: add zoom to mouse position * fix: remove check for pararllel projection * test(interaction): add zoom to mouse * fix(zoom-to-mouse): remove unreachable code * docs(interaction): add zoom to mouse position * fix(zoom-to-mouse): make static
Implementation same as Paraview
https://gitlab.kitware.com/paraview/paraview/-/blob/master/VTKExtensions/InteractionStyle/vtkPVInteractorStyle.cxx?ref_type=heads
and vtk-js
https://github.com/Kitware/vtk-js/blob/master/Sources/Interaction/Style/InteractorStyleManipulator/index.js
Fix: #901