Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve USD integration #1082

Merged
merged 7 commits into from
Dec 10, 2023
Merged

Improve USD integration #1082

merged 7 commits into from
Dec 10, 2023

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Nov 30, 2023 •
edited
Loading

  • Enable USD in python wheel tests
  • Build USD in monolithic mode
  • Patch destination of .dll libraries on Windows

@Meakk Meakk self-assigned this Nov 30, 2023
@Meakk Meakk force-pushed the python-usd branch 2 times, most recently from c7f83dc to 1ea8e6f Compare November 30, 2023 23:13
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93ec6da) 96.42% compared to head (ffe03fa) 96.43%.
Report is 12 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   96.42%   96.43%           
=======================================
  Files         124      124           
  Lines        7671     7682   +11     
=======================================
+ Hits         7397     7408   +11     
  Misses        274      274

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor

Can I do anything to help move this forward ?

@Meakk
Copy link
Member Author

Meakk commented Dec 4, 2023

Can I do anything to help move this forward ?

I moved the libraries to bin in Windows, but USD failed to load the plugins. I think we need to change PXR_INSTALL_LOCATION CMake variable too. I'll try it.

@Meakk Meakk changed the title Enable USD in python wheel CI Improve USD integration Dec 9, 2023
@Meakk Meakk requested a review from mwestphal December 9, 2023 14:55
@Meakk
Copy link
Member Author

Meakk commented Dec 9, 2023

@mwestphal please review

mwestphal
mwestphal requested changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes needed

mwestphal
mwestphal approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment about opening an issue upstream

@Meakk Meakk merged commit 4c54c72 into f3d-app:master Dec 10, 2023
45 checks passed
@Meakk Meakk deleted the python-usd branch December 10, 2023 19:23
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
@Meakk
Improve USD integration (#1082)
0aa2c68
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
Improve USD integration (f3d-app#1082)
a9c4886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meakk @mwestphal