-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve F3D logging system and add VTK output to --verbose #1085
Conversation
You are modifying libf3d public API! |
Looks reasonable to me |
I think that's ok. I also think that deprecating |
5fb7372
to
9a9e2b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 124 124
Lines 7682 7693 +11
=======================================
+ Hits 7408 7419 +11
Misses 274 274 ☔ View full report in Codecov by Sentry. |
56e0ab6
to
cdb5586
Compare
ddc92dd
to
2747154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment to address but it looks good to me
2747154
to
1a0f4bc
Compare
1a0f4bc
to
5479c0c
Compare
Improve F3D logging system and add VTK output to --verbose
Improve F3D logging system and add VTK output to --verbose
fix #966