Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve F3D logging system and add VTK output to --verbose #1085

Merged
merged 5 commits into from
Dec 10, 2023

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 4, 2023

fix #966

  • Transform --verbose into a string based option to select different level of verbosity
  • Deprecate --quiet
  • Change --no-render behavior by stopping having an effect on verbosity effect
  • Show VTK log when using debug verbosity

Copy link

github-actions bot commented Dec 4, 2023

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@Meakk
Copy link
Member

Meakk commented Dec 5, 2023

Looks reasonable to me

@Meakk
Copy link
Member

Meakk commented Dec 6, 2023

Is a string based option the right choice here ? I dont like using an integer value because it may be complex to add values in "between" and it may be unclear to users.

I think that's ok.

I also think that deprecating --quiet for --verbose=QUIET makes sense. Also, maybe it'd be more convenient if the value is case insensitive. Personally, I think --verbose=quiet looks nicer ^^

@mwestphal mwestphal force-pushed the thirdparties_debug branch 4 times, most recently from 5fb7372 to 9a9e2b0 Compare December 8, 2023 08:35
@mwestphal mwestphal requested a review from Meakk December 8, 2023 08:39
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c54c72) 96.43% compared to head (5479c0c) 96.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files         124      124           
  Lines        7682     7693   +11     
=======================================
+ Hits         7408     7419   +11     
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal force-pushed the thirdparties_debug branch 2 times, most recently from 56e0ab6 to cdb5586 Compare December 8, 2023 09:19
application/testing/CMakeLists.txt Show resolved Hide resolved
application/testing/CMakeLists.txt Outdated Show resolved Hide resolved
application/testing/CMakeLists.txt Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk December 8, 2023 11:29
@mwestphal mwestphal force-pushed the thirdparties_debug branch 2 times, most recently from ddc92dd to 2747154 Compare December 9, 2023 06:36
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment to address but it looks good to me

application/F3DStarter.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal merged commit 487e3e0 into f3d-app:master Dec 10, 2023
46 checks passed
mwestphal added a commit that referenced this pull request Feb 10, 2024
Improve F3D logging system and add VTK output to --verbose
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Improve F3D logging system and add VTK output to --verbose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add high verbosity mode and add VTK output to that high verbosity mode
2 participants