Fix/animation time zero issue #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 131 131
Lines 8202 8208 +6
=======================================
+ Hits 7916 7922 +6
Misses 286 286 ☔ View full report in Codecov by Sentry. |
mwestphal
reviewed
Feb 4, 2024
mwestphal
approved these changes
Feb 5, 2024
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
* Get method for time range added * Declaration of time range get method * Bug when animation time = zero fixed * Formatting fix * Unnecessary line * Formatting * Formatting * Test data added * Cmake tests added * Negative anim time test * Test baselines added * Requested argument changes * Tests passing now
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
* Get method for time range added * Declaration of time range get method * Bug when animation time = zero fixed * Formatting fix * Unnecessary line * Formatting * Formatting * Test data added * Cmake tests added * Negative anim time test * Test baselines added * Requested argument changes * Tests passing now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1222