-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a public vtkext module that can be used by both libf3d and plugins #1280
Conversation
f6a8061
to
77cd7c9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
- Coverage 96.44% 96.43% -0.02%
==========================================
Files 146 146
Lines 8715 8716 +1
==========================================
Hits 8405 8405
- Misses 310 311 +1 ☔ View full report in Codecov by Sentry. |
47d3e56
to
2c3f5f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Overall it looks very good :)
1c7b201
to
bc02148
Compare
This add a new vtkext module that can be used by both libf3d and plugins.
For now it contains only two classes but may be improved in the future.
It must depend only on itself and VTK, but the internal private VTK modules can depend on it.
This also split the
sdk
and theplugin_sdk
in two cmake installation components as well as split the find_package results in multiple parts,application
(f3d::f3d
),library
(f3d::libf3d
and include_dir) andpluginsdk
(f3d::vtkext and plugin macros)This also fix a potential segfault when loading an invalid plugin.
Fix: #1115
Installation result: