-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCCT speedups and fixes #1292
OCCT speedups and fixes #1292
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1292 +/- ##
==========================================
- Coverage 96.57% 96.57% -0.01%
==========================================
Files 138 138
Lines 8500 8553 +53
==========================================
+ Hits 8209 8260 +51
- Misses 291 293 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Why do we have a baseline change tho?
Not sure to be honest. I think it's because of the edges showing, that should have needed an update with the last PR that fixed the edges but it didn't (only the STEP one needed to be updated). But yeah I don't know why on this PR the IGES one failed and the STEP one didn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't pretend to understand everything but that looks good to me
Performance improvements for the OCCT reader:
XCAFDoc_ColorTool
were also wrong in addition to being slow, usingXCAFPrs
to walk down the attribute tree and collect inherited style properties is more correct and fasterall in all the 18MB step file from https://www.printables.com/model/612925-creality-k1-corexy-motion-assembly-cad/files now opens in about
40sec15sec instead of almost 5minbefore and after:
also fixes a minor bug where progress was reported up to 150%, meaning the progress bar would look full before the actual processing was finished.