maintain config declaration order #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1302 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 146 146
Lines 8715 8715
=======================================
Hits 8405 8405
Misses 310 310 ☔ View full report in Codecov by Sentry. |
mwestphal
approved these changes
Mar 8, 2024
mwestphal
reviewed
Aug 28, 2024
There was a problem hiding this comment.
wrong location for this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config blocks are currently matched by regex in alphabetical order which is counter-intuitive.
Technically it makes sense because JSON specifies dictionaries as unordered collections and F3D uses
std::mapfor storage, but this feels like unspecified behavior left to the implementation :(This PR uses
nlohmann::ordered_jsonandstd::vector<std::pair<...>>to maintain the top-down declaration order form the config file.