Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper event loop in libf3d #1770

Merged
merged 31 commits into from
Dec 16, 2024
Merged

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 8, 2024

  • Add an event loop API to interactor
  • Remove timer API from interactor
  • Rework animation tick logic to rely on event loop
  • Implement watch logic to rely on event loop
  • Integrate UI event loop into event loop
  • Add proper frame_rate support in interactor API
  • Removed libf3d option render.animation.frame_rate
  • Replaced --animation-frame-rate by more generic option frame-rate
  • Added a test for frame_rate
  • Updated doc
  • Fix Generalize approach to time management/temporal data #1534

Copy link

github-actions bot commented Dec 8, 2024

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base (9d08a55) to head (dbc556c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DUIActor.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files         123      123              
  Lines        9746     9745       -1     
==========================================
- Hits         9337     9336       -1     
  Misses        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal requested a review from Meakk December 12, 2024 21:45
@mwestphal mwestphal changed the title [draft] Event loop Implement proper event loop in libf3d Dec 12, 2024
application/F3DStarter.cxx Outdated Show resolved Hide resolved
library/private/animationManager.h Outdated Show resolved Hide resolved
library/src/animationManager.cxx Outdated Show resolved Hide resolved
library/testing/CMakeLists.txt Outdated Show resolved Hide resolved
library/public/interactor.h Outdated Show resolved Hide resolved
library/public/interactor.h Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
application/F3DStarter.cxx Outdated Show resolved Hide resolved
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

application/F3DOptionsTools.cxx Show resolved Hide resolved
examples/libf3d/cpp/multi-files/main.cxx Show resolved Hide resolved
library/src/animationManager.cxx Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/public/interactor.h Show resolved Hide resolved
library/public/interactor.h Show resolved Hide resolved
application/F3DStarter.cxx Outdated Show resolved Hide resolved
library/src/animationManager.cxx Outdated Show resolved Hide resolved
vtkext/private/module/vtkF3DImguiActor.cxx Show resolved Hide resolved
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo to fix

doc/libf3d/CLASSES.md Outdated Show resolved Hide resolved
Co-authored-by: Michael MIGLIORE <[email protected]>
@mwestphal mwestphal merged commit df62746 into f3d-app:master Dec 16, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize approach to time management/temporal data
2 participants