-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proper event loop in libf3d #1770
Conversation
You are modifying libf3d public API! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 123 123
Lines 9746 9745 -1
==========================================
- Hits 9337 9336 -1
Misses 409 409 ☔ View full report in Codecov by Sentry. |
1eb39da
to
68bd105
Compare
68bd105
to
dda37e1
Compare
dda37e1
to
bb26d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes needed
Co-authored-by: Michael MIGLIORE <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo to fix
Co-authored-by: Michael MIGLIORE <[email protected]>
render.animation.frame_rate
--animation-frame-rate
by more generic optionframe-rate
frame_rate