Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump "camera" info should dump information about all options #1809

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

samoncrief
Copy link
Contributor

@samoncrief samoncrief commented Dec 19, 2024

Implements #596

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (1021f00) to head (b3f89dc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
+ Coverage   95.71%   95.75%   +0.03%     
==========================================
  Files         125      125              
  Lines        9870     9885      +15     
==========================================
+ Hits         9447     9465      +18     
+ Misses        423      420       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

library/private/scene_impl.h Outdated Show resolved Hide resolved
library/src/scene_impl.cxx Show resolved Hide resolved
@mwestphal mwestphal merged commit 2bf1c71 into f3d-app:master Dec 31, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants