Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] More C++17 #1833

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

[draft] More C++17 #1833

wants to merge 25 commits into from

Conversation

mwestphal
Copy link
Contributor

No description provided.

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 89.71963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (1021f00) to head (edaee34).

Files with missing lines Patch % Lines
library/src/interactor_impl.cxx 76.66% 7 Missing ⚠️
application/F3DStarter.cxx 90.47% 2 Missing ⚠️
library/src/image.cxx 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1833      +/-   ##
==========================================
- Coverage   95.71%   95.55%   -0.16%     
==========================================
  Files         125      125              
  Lines        9870     9887      +17     
==========================================
+ Hits         9447     9448       +1     
- Misses        423      439      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal force-pushed the string_view branch 7 times, most recently from 69c90e3 to b64bfce Compare December 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant