Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear command #1836

Merged
merged 11 commits into from
Dec 30, 2024
Merged

Clear command #1836

merged 11 commits into from
Dec 30, 2024

Conversation

0xfedcafe
Copy link
Contributor

Added clear command and test as suggested in issue #1810

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (df562fe) to head (06ac7bc).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         125      125           
  Lines        9821     9832   +11     
=======================================
+ Hits         9399     9410   +11     
  Misses        422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution! Some changes needed though :)

Also, you need to update the doc in doc/user/COMMANDS.md

@mwestphal mwestphal requested a review from Meakk December 27, 2024 19:48
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks

@Meakk Meakk requested a review from mwestphal December 30, 2024 07:14
@mwestphal mwestphal merged commit 7770587 into f3d-app:master Dec 30, 2024
43 checks passed
@mwestphal
Copy link
Contributor

Thanks for your contribution @0xfedcafe !!!

@0xfedcafe 0xfedcafe deleted the clear-command branch December 31, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants