-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear command #1836
Clear command #1836
Conversation
b2afb96
to
7cbaa64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1836 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 125 125
Lines 9821 9832 +11
=======================================
+ Hits 9399 9410 +11
Misses 422 422 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution! Some changes needed though :)
Also, you need to update the doc in doc/user/COMMANDS.md
8e04afe
to
1c2ca91
Compare
1ed5bed
to
b4f3367
Compare
Co-authored-by: Mathieu Westphal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Thanks
Thanks for your contribution @0xfedcafe !!! |
Added clear command and test as suggested in issue #1810