Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options: Add support for parsing double dot in ratio #1839

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

mwestphal
Copy link
Contributor

No description provided.

@snoyer
Copy link
Contributor

snoyer commented Dec 26, 2024

could use const std::size_t sign = str.find_first_of("/:") so save looking through twice and avoid the mutable index

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (fda96ea) to head (3fd091e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
- Coverage   95.70%   95.67%   -0.04%     
==========================================
  Files         125      125              
  Lines        9821     9821              
==========================================
- Hits         9399     9396       -3     
- Misses        422      425       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal force-pushed the ratio_double_dot branch 2 times, most recently from 70ec657 to 36d0545 Compare December 26, 2024 08:00
@mwestphal mwestphal self-assigned this Dec 26, 2024
@mwestphal mwestphal merged commit df562fe into f3d-app:master Dec 27, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants