Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide console badge when rendering offscreen #1840

Merged
merged 6 commits into from
Dec 30, 2024

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Dec 26, 2024

Fix #1816

@Meakk Meakk self-assigned this Dec 26, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (7a649d4) to head (4bb0fb1).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1840   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         125      125           
  Lines        9821     9851   +30     
=======================================
+ Hits         9396     9425   +29     
- Misses        425      426    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk
Copy link
Member Author

Meakk commented Dec 30, 2024

Please review @mwestphal

@Meakk Meakk requested a review from mwestphal December 30, 2024 08:58
@Meakk Meakk merged commit 54b365b into f3d-app:master Dec 30, 2024
43 checks passed
@Meakk Meakk deleted the remove-console-badge branch December 30, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console badge should not be visible when rendering offscreen
2 participants