Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: Update API for C++17 #1841

Merged
merged 1 commit into from
Dec 30, 2024
Merged

engine: Update API for C++17 #1841

merged 1 commit into from
Dec 30, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 27, 2024 •
edited
Loading

  • Rewrite getPluginsList
  • Update API for C++17
  • Add/Update test for better testing and coverage
  • Improve some exceptions doc and logic

@github-actions GitHub Actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (54b365b) to head (f277612).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
library/src/engine.cxx 97.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
+ Coverage   95.68%   95.71%   +0.03%     
==========================================
  Files         125      125              
  Lines        9862     9870       +8     
==========================================
+ Hits         9436     9447      +11     
+ Misses        426      423       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal requested a review from Meakk December 28, 2024 11:26
Meakk
Meakk requested changes Dec 28, 2024
View reviewed changes
application/F3DPluginsTools.cxx Show resolved Hide resolved
library/src/engine.cxx Outdated Show resolved Hide resolved
library/src/engine.cxx Outdated Show resolved Hide resolved
library/src/engine.cxx Outdated Show resolved Hide resolved
library/src/engine.cxx Outdated Show resolved Hide resolved
library/src/window_impl.cxx Outdated Show resolved Hide resolved
library/testing/TestSDKEngine.cxx Outdated Show resolved Hide resolved
library/testing/TestSDKEngineExceptions.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal commented Dec 29, 2024
View reviewed changes
library/src/engine.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk December 29, 2024 19:16
Meakk
Meakk reviewed Dec 30, 2024
View reviewed changes
library/src/window_impl.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal force-pushed the engine_cxx17 branch 2 times, most recently from f2ce510 to 33754be Compare December 30, 2024 11:29
@mwestphal
engine: Update API for C++17
f277612 
 - Rewrite getPluginsList
 - Update API
@mwestphal mwestphal merged commit 1021f00 into f3d-app:master Dec 30, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwestphal @Meakk