Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test static analysis #1848

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Test static analysis #1848

merged 1 commit into from
Dec 29, 2024

Conversation

mwestphal
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (27d1e8a) to head (cde9013).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   95.67%   95.67%   -0.01%     
==========================================
  Files         125      125              
  Lines        9821     9819       -2     
==========================================
- Hits         9396     9394       -2     
  Misses        425      425              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor Author

Maybe related to a cppcheck issue ?

https://trac.cppcheck.net/ticket/13269

Anyway, lets fix it

@snoyer
Copy link
Contributor

snoyer commented Dec 29, 2024

the autos can be const auto& while you're in there

@Meakk
Copy link
Member

Meakk commented Dec 29, 2024

I'm curious about why it managed to find its way through the CI to the master.

@mwestphal mwestphal merged commit 93d7dee into f3d-app:master Dec 29, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants