kconfig/lxdialog: get ncurses CFLAGS with pkg-config and fixed btn color #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… color Fixed from vanilla kernel commit: be8af2d54a669 This makes "make menuconfig" also work on systems where ncurses is not installed in a standard location (such as on NixOS). This patch changes ldflags() and ccflags() so that it tries pkg-config first, and only if pkg-config fails does it go back to the fallback/manual checks. And, adding -DNCURSES_WIDECHAR=1 CFLAGS to prevent ncurses rendering wrong color on button when changing dialog color by wbkgdset().
|
@grapherd, Great work! |
|
@jserv It seems like travis CI problem, since it report After adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed from vanilla kernel commit: be8af2d54a669
This makes "make menuconfig" also work on systems where ncurses is not
installed in a standard location (such as on NixOS).
This patch changes ldflags() and ccflags() so that it tries pkg-config first,
and only if pkg-config fails does it go back to the fallback/manual checks.
And, adding -DNCURSES_WIDECHAR=1 CFLAGS to prevent ncurses rendering
wrong color on button when changing dialog color by wbkgdset().