scripts: New tool to dump init hooks #125
Conversation
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
| # | ||
| # Authors: |
There was a problem hiding this comment.
Don't mention "Authors" since we maintain the list in dedicated top-level files.
There was a problem hiding this comment.
I take the sample from Linux kernel scripts format. and fixed.
| self.files, hooks = s.split(':') | ||
|
|
||
| # Regex for splitting function and level | ||
| regex = r"\((.*?),(.*?)\)" |
There was a problem hiding this comment.
This will be a big problem since initializer element should be constant, according to c99 spec,
this mean we have these choice to init element.
6.4.4 Constants
Syntax
constant:
integer-constant (e.g. 4, 42L)
floating-constant (e.g. 0.345, .7)
enumeration-constant (stuff in enums)
character-constant (e.g. 'c', '\0')
6.6 Constant expressions
(7) More latitude is permitted for constant expressions in initializers. Such a constant expression shall be, or evaluate to, one of the following:
— an arithmetic constant expression,
— a null pointer constant,
— an address constant, or
— an address constant for an object type plus or minus an integer constant expression.
(8) An arithmetic constant expression shall have arithmetic type and shall only have operands that are integer constants, floating constants, enumeration constants, character constants, and sizeof expressions. Cast operators in an arithmetic constant expression shall only convert arithmetic types to arithmetic types, except as part of an operand to a sizeof operator whose result is an integer constant.
That mean we can have these valid input, but can't valuate in python
enum foobar {
foo = 5,
bar = 10,
};
INIT_HOOK(function, (int) &thread_init_subsys);
INIT_HOOK(function, bar);
INIT_HOOK(thread_init_subsys, SSI_NORMAL_THREAD);
INIT_HOOK(thread_init_subsys, 50L);There was a problem hiding this comment.
I'll make a workaround method for now. but still need to think some method to count on it.
There was a problem hiding this comment.
You can even generate headers to be included for init hooks as we did for mconf. I did the similar hack for raytracing program as well.
There was a problem hiding this comment.
Yep, I found that we can read it from .init_hook section in obj file
Contents of section .init_hook:
0000 afbeadde 00000000 00000000 ............
will that be a better method to get level when eval failed?
There was a problem hiding this comment.
Retrieving ELF section from given files is a practical way. @arcbbb did that for Kprobe (yes, F9 has the feature.) by means of similar technique.
|
|
||
| def __init__(self, infile=None): | ||
| # Hack for board build prefix | ||
| self.board = { |
There was a problem hiding this comment.
Parsing defconfig such as board/discoveryf4/defconfig is straightforward rather than hardcode.
There was a problem hiding this comment.
Is about self.board or other thing ?
The problem here is we need to specify user's config board for build/prefix, so only read from .config file and program can determine which board is using now.
And pair of board -> build prefix was existed in top dir Makefile if else block
ifeq "$(CONFIG_BOARD_STM32F429DISCOVERY)" "y"
BOARD ?= discoveryf429
else ifeq "$(CONFIG_BOARD_STM32P103)" "y"
BOARD ?= stm32p103
else
BOARD ?= discoveryf4
endif
rather than making a turly parser, I make this attr set when parsing .config, since we will only get one CONFIG_BOARD=y in config file.
| @@ -0,0 +1,101 @@ | |||
| #!/usr/bin/python | |||
| # | |||
| # Scripts for print all init hooks in f9-kernel. | |||
There was a problem hiding this comment.
Eliminate Line 3. We already have descriptions.
|
The subject of GIT commit messages can be "scripts: New tool to dump init hooks". |
|
Rebase all commit to one? |
louisom
changed the title
|
@grapherd , Yes, please do. |
Introducing new tool to dump init hook in f9-kernel.
At now this script will dump init hook by hook level,
but if hook is at same level, is may not dump by the
real sequence when kernel perform run_init_hook in runtime.
This tool's mechanism for getting hook level is to parse
source code and use regex to get `INIT_HOOK(hander, hook_level)`,
hook_level will be eval in python and for fallback, it will parse
object file in build directory to get hook level, so you'll need
to bulid a full f9-kernel, and get setup GNU toolchain at first.
Also, this tool will get some information from config file
like `.config`, `Makefile`, `mk/toolchain.mk` for some
general setting variable: BOARD, CROSS_COMPILE...etc
Class MakefileConfig perform will config interface.
Parser in MakefileConfig can only parse makefile `?=` variable when
the attribute is not set. (it only serive for BOARD and CROSS_COMPILE
for now)
for example:
c = MakefileConfig() # Create new object,
# also load .config into it.
c.CONFIG_DEBUG # Return True
c.CONFIG_LOADER # Raise KeyError
c.parse_makefile('Makefile') # Parsing 'Makefile'
c.BOARD # Return config board
c.out # build/$(BOARD)
As I say, it only impl very low parsing process for makefile,
so you can see the last example return `build/$(BOARD)`, thought
$(BOARD) has been set in object c, it still won't convert to
`build/stm32p103` style for now.
At now this script will print by hook level,
but is not the real seq when kernel perform run_init_hook.