Added stm32l476 support, trivial source code cleanup #147
Conversation
|
@Kochise Thanks for the porting to stm32L476, but it seems broke the build of the exists board on CI and locals (which I build on my computer and raise the error, too). Could you help to check the build error, and fix it? |
|
Will check https://travis-ci.org/f9micro/f9-kernel/builds/217574958 this week-end and provide a makeit script for the corrected source. |
|
ipc.c, line 251, remove the badly formatted line :
|
|
Also forgot to modify original build scripts to include the new board/platform, sorry, will commit that asap. |
board/nucleol476rg/board.c
Outdated
| @@ -0,0 +1,32 @@ | |||
| /* Copyright (c) 2016 The F9 Microkernel Project. All rights reserved. | |||
There was a problem hiding this comment.
You can bump the date to 2017 since your contributions show up.
kernel/interrupt.c
Outdated
| if (user_irq_queue_is_empty()) | ||
| return NULL; | ||
|
|
||
| struct user_irq *uirq = user_irq_queue.head; | ||
| uirq = user_irq_queue.head; |
There was a problem hiding this comment.
Can you split the changes against directory kernel/ in another commit?
There was a problem hiding this comment.
Will also do that, since I'm also moving sources (board, external, kernel, loader, platform, user) into a \src folder
kernel/interrupt.c
Outdated
| @@ -98,14 +101,17 @@ static void user_irq_queue_delete(int irq) | |||
|
|
|||
| static inline void user_irq_reset_all(void) | |||
| { | |||
| for (int i = 0 ; i < IRQn_NUM ; i++) | |||
| int i; | |||
| for (i = 0 ; i < IRQn_NUM ; i++) | |||
There was a problem hiding this comment.
Can't your compiler support C99 features like the statement for (int i = 0 ; i < IRQn_NUM ; i++)?
|
Hmmm, perhaps I should install a Linux VM with Travis to test my builds against regular toolchains before committing :/ |
|
OK, got it to compile, now I have to revert my commits back to origin and recommit them in two batches, one for the stm32l476 support, one for the kernel code 'beautification'. |
Source code cleanup made for static analyzers