Add support for endless method definitions #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #399
On the tin -- endless method definitions are ~the same as regular definitions in Ripper, the only difference being that instead of an array of expressions (and the optional rescue/ensure/etc.), it returns only a single expression.
In terms of style, this PR does nothing special -- endless method definitions just render expressions the same as e.g. an assignment. Note that they don't increase the indentation level here, same as variable assignments (although that's not a strong opinion, happy to change that if we want), so multiline expressions do end up left-aligned. (My only reasoning for this is that it looks a little strange to indent it without an
endsomewhere 🤷)