Push image build in from PR #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavlin
force-pushed
the
feature/push-PR-build
branch
3 times, most recently
from
fceb724 to
e8c0fda
Compare
vpavlin
force-pushed
the
feature/push-PR-build
branch
from
e8c0fda to
7f149ec
Compare
|
Do we still want to merge this? What is the idea? Each pull request builds an image and pushes it? Then you can manually deploy it? |
|
Yeah, that was my idea to try out, but with your solution to run locally, we might not need to pollute the registry |
I actually like this, but we can see how far we get with the ability to run locally. I created issue #147 to track this and we can always dig out this change of yours this way. Closing this pull request for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.