fix: Using an odd number of elements in strokeDashArray will contaminate the original data #10293
+20
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate the original data
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
I would try to remove the logic and see if node canvas is happy with it. If it isn't we need to keep the logic |
|
node canvas seems ok with removing the full logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10292
I found that the native Canvas API setLineDash supports odd-numbered arrays, and it automatically converts them into an even-numbered array. Can we remove our processing logic and directly pass an odd-numbered array without any additional handling?
The current modification follows the previous logic without changing the source array.