OMM: Bring in SQLAlchemy, get database working #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcallies
approved these changes
Aug 17, 2023
dougneal
force-pushed
the
omm-sqlalchemy-etc
branch
from
3b84ce5
to
9eeefa1
Compare
dougneal
changed the title
|
I should probably update the |
dougneal
force-pushed
the
omm-sqlalchemy-etc
branch
from
9eeefa1
to
828838a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring in SQLAlchemy, Alembic, and the Flask integrations for them.
I've added a couple of models/dataclasses/tables - banks and hashes - really just something super basic to get us started, I expect this to change a lot.
There was some discussion about whether to use plain dataclasses with separate ORM classes; we can still do that if we want to.
Test Plan
Rebuild the dev container and watch the tables be created!