Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytx] Add py.typed marker to threatexchange #1356

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[pytx] Add py.typed marker to threatexchange #1356

merged 2 commits into from
Sep 8, 2023

Conversation

Dcallies
Copy link
Contributor

@Dcallies Dcallies commented Sep 8, 2023

Some percentage of this library is typed, and I think this is the correct way to mark it.

In a following PR I'll bump the version number.

@github-actions github-actions bot added the python-threatexchange Items related to the threatexchange python tool / library label Sep 8, 2023
@jennylin
Copy link
Contributor

jennylin commented Sep 8, 2023

looks reasonable as far as I can tell!

@jennylin jennylin closed this Sep 8, 2023
@Dcallies Dcallies reopened this Sep 8, 2023
Copy link

@Chuwiey Chuwiey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Chuwiey
Copy link

Chuwiey commented Sep 8, 2023

go forth and prosper!

@Dcallies Dcallies merged commit e62fcaf into main Sep 8, 2023
11 checks passed
Copy link
Contributor

@jennylin jennylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as far as I can tell)

@Dcallies Dcallies deleted the typed_marker branch October 3, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed python-threatexchange Items related to the threatexchange python tool / library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants