Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dev:query_media function as it's no longer used #1649

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

prenner
Copy link
Contributor

@prenner prenner commented Oct 3, 2024

Summary

remove dev/query_media function as it's no longer used. existing, non dev endpoints have the same functionality

Test Plan


from OpenMediaMatch.utils import dev_utils
from OpenMediaMatch import persistence
from OpenMediaMatch.storage.postgres.flask_utils import reset_tables


from threatexchange.exchanges.fetch_state import CollaborationConfigBase
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the whole query_media function I don't see it being used anywhere.

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI = green; I merge

@prenner prenner changed the title add missing str_to_bool import to development.py remove dev:query_media function as it's no longer used Oct 3, 2024
@dougneal dougneal merged commit 8ef7735 into facebook:main Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants