Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cli to remove python 3.8 and add python 3.12 #1663

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Mackay-Fisher
Copy link
Contributor

@Mackay-Fisher Mackay-Fisher commented Oct 17, 2024

Removed the Python 3.8 CI, and added the Python 3.12 CI. Fixes issue #1661

Tested by creating a pr in my forked repository to trigger the python-threat exchange CI workflow on the updated branch and verified that all three tests (3.9, 3.11, 3.12) passed.

Link to updated workflow verification: https://github.com/Mackay-Fisher/ThreatExchange/actions/runs/11376387652

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Our dependencies started blocking 3.8, so this is quite timely!

@Dcallies Dcallies merged commit aa6cca1 into facebook:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants