Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-tx] Ncmec api feedback fixups #1667

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[py-tx] Ncmec api feedback fixups #1667

merged 3 commits into from
Nov 4, 2024

Conversation

Dcallies
Copy link
Contributor

Summary

  • I worked on this during the hackathon, but never finished submitting it
  • Most of this is minor QoL fixups from @aryzle's work - thanks arzyle!

Test Plan

  • Manually submitted to test_NGO database using Meta credentials, then re-read to confirm updates were sent
  • Existing unittests cover the refactored bit, and as proven by the need to e2e test this, it's hard to test the finnicky bits

@Dcallies Dcallies merged commit 7bc4c3c into facebook:main Nov 4, 2024
6 checks passed
@Dcallies Dcallies deleted the ncmec_api_feedback_tweaks branch November 4, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dcallies @facebook-github-bot