Add check, tests and ubuntu to CI

facebook · Sep 5, 2023 · fe852fd · fe852fd
1 parent 0d9a59d
commit fe852fd
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 16 deletions.
diff --git a/.clang-format b/.clang-format
@@ -43,7 +43,6 @@ BraceWrapping:
   SplitEmptyNamespace: false
 BreakBeforeBinaryOperators: None
 BreakBeforeBraces: Custom
-BreakBeforeConceptDeclarations: Always
 BreakBeforeTernaryOperators: false
 BreakConstructorInitializers: AfterColon
 BreakInheritanceList: AfterColon
@@ -78,11 +77,8 @@ IndentCaseLabels: false
 IndentExternBlock: NoIndent
 IndentGotoLabels: false
 IndentPPDirectives: None
-IndentRequiresClause: true
 IndentWidth: 4
 IndentWrappedFunctionNames: false
-InsertBraces: false
-#InsertTrailingCommas: Wrapped
 KeepEmptyLinesAtTheStartOfBlocks: false
 LambdaBodyIndentation: Signature
 MaxEmptyLinesToKeep: 1
@@ -92,7 +88,6 @@ PointerAlignment: Right
 QualifierAlignment: Leave
 ReferenceAlignment: Right
 ReflowComments: true
-RequiresClausePosition: OwnLine
 SeparateDefinitionBlocks: Always
 SortIncludes: CaseSensitive
 SortUsingDeclarations: true
@@ -113,8 +108,6 @@ SpaceBeforeParensOptions:
   AfterFunctionDefinitionName: false
   AfterIfMacros: true
   AfterOverloadedOperator: false
-  AfterRequiresInClause: true
-  AfterRequiresInExpression: true
   BeforeNonEmptyParentheses: false
 SpaceBeforeRangeBasedForLoopColon: false
 SpaceBeforeSquareBrackets: false

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -7,27 +7,74 @@ on:
     branches:
       - main
 
+permissions:
+  checks: write
+  pull-requests: write
+
 jobs:
   build:
     runs-on: ubuntu-22.04
-    container: fedora:38
     strategy:
       fail-fast: false
       matrix:
-        buildtype:
-          - debug
-          - release
+        buildtype: [ 'debug', 'release' ]
+        image: [ 'fedora:38', 'ubuntu:22.04' ]
+    container: ${{ matrix.image }}
     steps:
-      - name: Install packages
+      - name: Install packages Fedora
+        if: matrix.image == 'fedora:38'
         run: |
           sudo dnf -y install 'dnf-command(copr)'
           sudo dnf -y copr enable naccyde/criterion 
-          sudo dnf -y install cmake libbpf-devel \
-                              criterion-devel clang-tools-extra lcov libasan libubsan \
-                              doxygen python3-sphinx python3-breathe python3-furo
+          sudo dnf -y install \
+            clang-tools-extra \
+            cmake \
+            criterion-devel \
+            doxygen \
+            lcov \
+            libasan \
+            libbpf-devel \
+            libubsan \
+            python3-breathe \
+            python3-furo \
+            python3-sphinx
+      - name: Install packages Ubuntu
+        if: matrix.image == 'ubuntu:22.04'
+        run: |
+          sudo apt-get update
+          sudo DEBIAN_FRONTEND=noninteractive TZ=Etc/UTC apt-get -y install \
+            clang-format \
+            clang-tidy \
+            cmake \
+            doxygen \
+            lcov \
+            libbpf-dev \
+            libcriterion-dev \
+            python3-breathe \
+            python3-pip \
+            python3-sphinx
+          pip install furo
       - name: Check out repository code
         uses: actions/checkout@v3
       - name: Configure build
         run: cmake -B $GITHUB_WORKSPACE/build -S $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=${{ matrix.buildtype }}
       - name: Build
         run: make -C $GITHUB_WORKSPACE/build
+      - name: Check style
+        if: matrix.buildtype == 'release'
+        run: make -C $GITHUB_WORKSPACE/build checkstyle
+      - name: Run unit tests
+        run: make -C $GITHUB_WORKSPACE/build test
+      - name: Coverage
+        if: matrix.buildtype == 'Debug' && matrix.image == 'fedora:38'
+        run: make -C $GITHUB_WORKSPACE/build coverage
+      - name: Upload coverage report to Codecov
+        if: matrix.buildtype == 'Debug' && matrix.image == 'fedora:38'
+        uses: codecov/codecov-action@v3
+        with:
+          files: build/doc/lcov.out
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      - name: Generate documentation
+        if: matrix.buildtype == 'release'
+        run: make -C $GITHUB_WORKSPACE/build doc
diff --git a/tests/unit/CMakeLists.txt b/tests/unit/CMakeLists.txt
@@ -48,7 +48,7 @@ target_link_options(tests_unit
 )
 
 add_custom_target(test
-    COMMAND $<TARGET_FILE:tests_unit> --verbose
+    COMMAND $<TARGET_FILE:tests_unit> --verbose --xml=test-report.xml
     DEPENDS tests_unit
     COMMENT "Running unit tests"
 )