General improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPF_NETFILTER program type support introduced 2-step BPF program loading, but the post-unload callback for TC wasn't available. Signed-off-by: Quentin Deslandes <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 13.77% 13.49% -0.29%
==========================================
Files 33 33
Lines 2388 2283 -105
==========================================
- Hits 329 308 -21
+ Misses 2059 1975 -84
☔ View full report in Codecov by Sentry. |
BPF_EXIT_INSN() is added to the codegen by the rules, or the program itself. The flavour doesn't need to add a BPF_EXIT_INSN(). Signed-off-by: Quentin Deslandes <[email protected]>
Install bpfilter.pc into CMake's libdir instead of datadir. Add ubsan and asan to bpfilter.pc in debug mode. Signed-off-by: Quentin Deslandes <[email protected]>
ipt_getinfo and ipt_get_entries are both used (as a pointer) but undefined in bpfilter.h. Forward-declare both structure to prevent compilation warning. Signed-off-by: Quentin Deslandes <[email protected]>
Signed-off-by: Quentin Deslandes <[email protected]>
Do not read bf_response.data_len in bf_recv_response() if bf_response.status is not successful. Signed-off-by: Quentin Deslandes <[email protected]>
qdeslandes
force-pushed
the
general_improvements
branch
from
87fc416
to
24e3d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.