Collapse write barrier function for HV and SHV #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62158417 |
lavenzg
force-pushed
the
export-D62158417-to-static_h
branch
from
582f66a
to
312fcf8
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 22, 2024
Summary: Collapse them to `GCHermesValueBase` since the implementation is exactly the same. This will make future changes to these functions easier. Differential Revision: D62158417
|
This pull request was exported from Phabricator. Differential Revision: D62158417 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62158417 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
Summary: Pull Request resolved: facebook#1501 Collapse them to `GCHermesValueBase` since the implementation is exactly the same. This will make future changes to these functions easier. Differential Revision: D62158417
lavenzg
force-pushed
the
export-D62158417-to-static_h
branch
from
312fcf8
to
b3db0ce
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebook#1501 Collapse them to `GCHermesValueBase` since the implementation is exactly the same. This will make future changes to these functions easier. Differential Revision: D62158417
|
This pull request was exported from Phabricator. Differential Revision: D62158417 |
lavenzg
force-pushed
the
export-D62158417-to-static_h
branch
from
b3db0ce
to
5e38b5f
Compare
Differential Revision: D61675022
…er (facebook#1504) Summary: Pull Request resolved: facebook#1504 Large segment needs to be backed by a large storage size. StorageProvider currently always allocate fixed size of storage determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE. This diffs adds support of allocating larger storage with below changes: 1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter. 2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply change the previous fixed storage size to passed in `sz`. 3. For `ContiguousVAStorageProvider`, use a BitVector to manage allocations and deallocations. This can be improved later if we observe fragmentations. The support of enabling different sizes of heap segment will be added later. Differential Revision: D61676721
Differential Revision: D61747499
Differential Revision: D61807366
Differential Revision: D65828323
Differential Revision: D61747510
Differential Revision: D64713261
Differential Revision: D65638010
Summary: Pull Request resolved: facebook#1501 Collapse them to `GCHermesValueBase` since the implementation is exactly the same. This will make future changes to these functions easier. Differential Revision: D62158417
|
This pull request was exported from Phabricator. Differential Revision: D62158417 |
lavenzg
force-pushed
the
export-D62158417-to-static_h
branch
from
5e38b5f
to
0e60c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Collapse them to
GCHermesValueBasesince the implementation isexactly the same. This will make future changes to these functions
easier.
Differential Revision: D62158417