Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the pointer of owning object in GCPointer::set() part I #1502

Open
wants to merge 13 commits into
base: static_h
Choose a base branch
from
Open

Pass the pointer of owning object in GCPointer::set() part I #1502

wants to merge 13 commits into from

Commits on Nov 26, 2024

  1. Define AlignedHeapSegmentBase 

    Differential Revision: D61675022
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    43da9ea View commit details
    Browse the repository at this point in the history

  2. Add support of allocating different sizes of storage in StorageProvid… 

    …er (facebook#1504)

Summary:
Pull Request resolved: facebook#1504

Large segment needs to be backed by a large storage size.
StorageProvider currently always allocate fixed size of storage
determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE.

This diffs adds support of allocating larger storage with below
changes:
1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter.
2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply
change the previous fixed storage size to passed in `sz`.
3. For `ContiguousVAStorageProvider`, use a BitVector to manage
allocations and deallocations. This can be improved later if we observe
fragmentations.

The support of enabling different sizes of heap segment will be added
later.

Differential Revision: D61676721
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c70e0e4 View commit details
    Browse the repository at this point in the history

  3. Let SHSegmentInfo be explicit in CardTable 

    Differential Revision: D61747499
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    02678e7 View commit details
    Browse the repository at this point in the history

  4. Store segment size in SHSegmentInfo 

    Differential Revision: D61807366
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b123301 View commit details
    Browse the repository at this point in the history

  5. Allow passing segment size to AlignedHeapSegmentBase 

    Differential Revision: D65828323
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b60066b View commit details
    Browse the repository at this point in the history

  6. Allow allocating CardStatus/Boundary array separately in CardTable 

    Differential Revision: D61747510
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4e9bf16 View commit details
    Browse the repository at this point in the history

  7. Store current cell in SlotAcceptor, [SH] Move rest CardTable function… 

    …s to AlignedHeapSegmentBase

Differential Revision: D64713261
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5aaedd1 View commit details
    Browse the repository at this point in the history

  8. Add allowLargeAlloc to GCCell VTable 

    Differential Revision: D65638502
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3facc36 View commit details
    Browse the repository at this point in the history

  9. Update constructorWriteBarrierRange 

    Differential Revision: D62171114
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b8afc2d View commit details
    Browse the repository at this point in the history

  10. Add a findObject function to CardTable for assertions in writer barri… 

    …ers (facebook#1513)

Summary: Pull Request resolved: facebook#1513

Differential Revision: D62169632
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    eee3346 View commit details
    Browse the repository at this point in the history

  11. Split of "[SH] Add write barrier variants that support large allocation" 

    Differential Revision: D65701671
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2347115 View commit details
    Browse the repository at this point in the history

  12. Add owning cell to parameters of GCHermesValueBase::set(), [SH] Add o… 

    …wning cell to ctor of GCHermesValueBase

Differential Revision: D62196480
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    32a3f9c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Pass the pointer of owning object to GCPointer constructor and set me… 

    …thod (facebook#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    503a099 View commit details
    Browse the repository at this point in the history