Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSXAttributeInitializer #49

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Conversation

jmm
Copy link
Contributor

@jmm jmm commented Feb 1, 2016

Support for boolean attributes (e.g. <X y /> vs <X y={true} />) is already advertised (JSX in Depth, facebook/react#2536 (comment)) and implemented (e.g. Babel), so I'm thinking it should be reflected here?

@RReverser
Copy link
Contributor

Yeah, good catch. LGTM.
/cc @sebmarkbage

sebmarkbage added a commit that referenced this pull request Feb 1, 2016
Add JSXAttributeInitializer
@sebmarkbage sebmarkbage merged commit 3f745f4 into facebook:master Feb 1, 2016
@jmm
Copy link
Contributor Author

jmm commented Feb 1, 2016

Thanks!

@jmm jmm deleted the attr-init-opt branch February 1, 2016 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants