Add __id to LSP completions #4839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn resolve_completion_items_typename(type_: Type, schema: &SDLSchema) -> Vec<CompletionItem> { | ||
| fn resolve_special_completion_items(type_: Type, schema: &SDLSchema) -> Vec<CompletionItem> { | ||
| let __id_item = CompletionItem { | ||
| label: "__id".to_owned(), |
There was a problem hiding this comment.
I wonder if this should be exposed by the SDLSchema? A little nervous having this fieldname and type hard coded in multiple modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of our developers reached out, because they weren't sure if they're using
__idin the right places, since the LSP wouldn't suggest it.I've extended the LSP completions to include the
__idfield to clear up those confusions.To my knowledge the
__idfield should be a valid selection on any complex type. If there are special cases, please let me know and I'll update the implementation for the suggestion accordingly.